🐛(tests) configure DRF in lms settings & use lms settings in tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
changed the title
jmaupetit
force-pushed
the
fix-api-versionning
branch
3 times, most recently
from
16ed908 to
3125e5c
Compare
jmaupetit
force-pushed
the
fix-api-versionning
branch
from
3125e5c to
dfb46ca
Compare
sampaccoud
reviewed
Mar 21, 2018
| RUN if [ ${user} -ne 0 -a ${group} -ne 0 ]; then \ | ||
| groupadd --gid $group app ; \ | ||
| useradd --uid $user --gid $group --home /app app ; \ | ||
| fi |
There was a problem hiding this comment.
use redhat pattern as we don't want to create images that work only with one user?
There was a problem hiding this comment.
If you don't mind I would prefer to handle this in a new PR as it requires substantial changes. I'll declare a new issue for this. Deal?
| - CI_STEP=quality | ||
| - CI_STEP=docs | ||
| - CI_STEP=test | ||
| - CI_STEP=test-spec OPENEDX_RELEASE=ginkgo.1 |
There was a problem hiding this comment.
I thought you were removing Travis?
There was a problem hiding this comment.
I will. Not in this PR. I'll declare another issue for this. Deal?
| echo "Running tox:$TOXENV test suite..." | ||
| # Perform database migrations | ||
| echo "Starting database migration" | ||
| _dc_run lms python ./manage.py lms migrate |
There was a problem hiding this comment.
Fonzie is installed in the LMS application. Is the LMS standalone, or does it requires the CMS to run?
There was a problem hiding this comment.
ok so maybe remove it from elsewhere?
cchaudier
reviewed
Mar 21, 2018
bin/ci
Outdated
| ;; | ||
| test) | ||
| make test | ||
| ;; |
There was a problem hiding this comment.
Line 95 -> 103 ca be replaced by
docs|quality|test)
make $CI_STEP
;;
jmaupetit
changed the title
sampaccoud
approved these changes
Mar 27, 2018
cchaudier
approved these changes
Mar 27, 2018
** FIX DETAILS ** * configure & test DRF API versioning * use lms settings in tests * get rid of tox in our CI: Using tox within docker containers seems overkill; let's make things a little bit "simpler" by dropping it once for all. * Prevent root user creation: when trying to build the base container with no user or group as build arguments, docker tries to create the root user. We prevent this behavior by only creating a user when uid:gid are distinct from root user ids. * Update volume endpoints: fundocker/edxapp now use the same application tree as edx, we need to stick to it to make it works. ** MISC ** * fix broken comparison in ci script * use super() in test cases setUp method * remove unused CMS service * improve CI step switch/case
jmaupetit
force-pushed
the
fix-api-versionning
branch
from
13edc15 to
c0980f4
Compare
jmaupetit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to use lms settings in our tests so that we are in an Open edX context.
Proposal
tox