[influxdb] Implement ModifiablePersistenceService #14959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will replace #12935. |
jlaur
requested changes
May 9, 2023
There was a problem hiding this comment.
Thanks! A few minor comments from my side. @florian-h05 - do you want to have a look also? I don't use InfluxDB myself. @J-N-K - since you are testing this already, would it be possible to verify #14806 also so we could get that merged?
...ence.influxdb/src/main/java/org/openhab/persistence/influxdb/InfluxDBPersistenceService.java
Outdated
Show resolved
Hide resolved
...nce.influxdb/src/main/java/org/openhab/persistence/influxdb/internal/InfluxDBRepository.java
Outdated
Show resolved
Hide resolved
Comment on lines
+159
to
+162
| OffsetDateTime start = Objects.requireNonNullElse(filter.getBeginDate(), ZonedDateTime.now().minusYears(100)) | ||
| .toOffsetDateTime(); | ||
| OffsetDateTime stop = Objects.requireNonNullElse(filter.getEndDate(), ZonedDateTime.now().plusYears(100)) | ||
| .toOffsetDateTime(); |
There was a problem hiding this comment.
Is there a particular reason for using now +/- 100 years rather than OffsetDateTime.MIN/OffsetDateTime.MAX, for example? I should add that I don't know the internals of InfluxDB and the used API.
There was a problem hiding this comment.
That's a very good question. I just kept it the same way it is done for missing start/end dates in other queries.
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
|
@jlaur I think I addressed all your comments. |
tb4jc
pushed a commit
to tb4jc/openhab-addons
that referenced
this pull request
Jun 19, 2023
* [influxdb] Implement ModifiablePersistenceService Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Thomas Burri <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
* [influxdb] Implement ModifiablePersistenceService Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Matt Myers <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [influxdb] Implement ModifiablePersistenceService Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. This will be needed to store forecasts or retrospectivly added data.