Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tellstick] Add null annotations #17974

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[tellstick] Add null annotations #17974

wants to merge 7 commits into from
+192 −114

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Dec 24, 2024

  • Add null annotations
  • Fixed most warnings as a result of adding null annotations.

@lsiepel lsiepel requested a review from a team as a code owner December 24, 2024 20:09
jlaur
jlaur requested changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the annotations and warnings. Can you rebase to make the dependency upgrades disappear? 🙂

...ick/src/main/java/org/openhab/binding/tellstick/internal/conf/TelldusLocalConfiguration.java Outdated Show resolved Hide resolved
...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Outdated Show resolved Hide resolved
...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Outdated Show resolved Hide resolved
...k/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreDeviceController.java Outdated Show resolved Hide resolved
...tick/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveBridgeHandler.java Outdated Show resolved Hide resolved
...k/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveDeviceController.java Outdated Show resolved Hide resolved
lsiepel and others added 5 commits December 28, 2024 14:57
@lsiepel @jlaur
Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…
f62861b 
…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java

Co-authored-by: Jacob Laursen <[email protected]>
Signed-off-by: lsiepel <[email protected]>
@lsiepel @jlaur
Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…
1329b3e 
…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java

Co-authored-by: Jacob Laursen <[email protected]>
Signed-off-by: lsiepel <[email protected]>
@lsiepel @jlaur
Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…
e83c197 
…b/binding/tellstick/internal/live/TelldusLiveDeviceController.java

Co-authored-by: Jacob Laursen <[email protected]>
Signed-off-by: lsiepel <[email protected]>
@lsiepel
Merge branch 'openhab:main' into tellstick-null-annotations
b5baad7
@lsiepel
Fix review comments
d718cb6 
Signed-off-by: Leo Siepel <[email protected]>
@jlaur
Copy link
Contributor

jlaur commented Jan 6, 2025

@lsiepel - unfortunately I missed to merge this before New Year. There are now some conflicts to resolve, probably because of #18015.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @jlaur