Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicStateDescriptionProvider fixes #5957

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

Hilbrand
Copy link
Member

Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See #3619

Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@Hilbrand Hilbrand requested review from J-N-K and mgeramb as code owners August 20, 2019 20:19
@TravisBuddy
Copy link

Travis tests were successful

Hey @Hilbrand,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Member

@mgeramb mgeramb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to know that returning null is allowed here

@kaikreuzer kaikreuzer merged commit 9df69bc into openhab:master Aug 21, 2019
@Hilbrand Hilbrand deleted the dynamic_fix branch August 21, 2019 06:10
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/released-openhab2-amazon-echo-control-binding-controlling-alexa-from-openhab2/37844/1948

chaton78 pushed a commit to chaton78/openhab-addons that referenced this pull request Sep 2, 2019
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Pascal Larin <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn added this to the 2.5 milestone Sep 29, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Dec 8, 2019
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Tim Roberts <[email protected]>
hww3 pushed a commit to hww3/openhab2-addons that referenced this pull request Feb 22, 2020
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants