-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicStateDescriptionProvider fixes #5957
Conversation
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619 Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Travis tests were successfulHey @Hilbrand, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to know that returning null is allowed here
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619 Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Pascal Larin <[email protected]>
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619 Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619 Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619 Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Tim Roberts <[email protected]>
Don't return originalStateDescription as the service code depends on it being null if the specific provider called isn't handling the channel. See openhab#3619 Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Don't return
originalStateDescription
as the service code depends on it being null if the specific provider called isn't handling the channel. See #3619