Some non null annotations #4486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaël L'hopital <[email protected]>
holgerfriedrich
requested changes
Jan 15, 2025
...les/org.openhab.core/src/main/java/org/openhab/core/internal/service/BundleResolverImpl.java
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/util/BundleResolver.java
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/items/RegistryHook.java
Show resolved
Hide resolved
| return getText(null, key, locale); | ||
| } | ||
|
|
||
| private String getTranslatedText(String resourceName, String key, Locale locale) { | ||
| private @Nullable String getTranslatedText(String resourceName, String key, Locale locale) { |
There was a problem hiding this comment.
The parameters may be Nullable as well. According to the docs, it would cause a NullpointerException in getBundle, which leads to returning null.
Not sure if this is the way to go, but at least it would be more consistent with the other methods above.
Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.