Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add androidtv logo #2001

Merged
merged 3 commits into from
Feb 6, 2023
Merged

add androidtv logo #2001

merged 3 commits into from
Feb 6, 2023

Conversation

morph166955
Copy link
Contributor

Add logo for the new androidtv binding: openhab/openhab-addons#14282

Signed-off-by: Ben Rosenblum [email protected]

Signed-off-by: Ben Rosenblum <[email protected]>
@netlify
Copy link

netlify bot commented Feb 1, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit d97cc42
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/63e02c5debb10c0009b60c05
😎 Deploy Preview https://deploy-preview-2001--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Hilbrand
Copy link
Member

Hilbrand commented Feb 2, 2023

Looks like the logo is larger than the required 512x512. See; https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

Signed-off-by: Ben Rosenblum <[email protected]>
@morph166955
Copy link
Contributor Author

Looks like the logo is larger than the required 512x512. See; https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

Sorry, fixed now. Thank you!

@Hilbrand
Copy link
Member

Hilbrand commented Feb 2, 2023

Not to put on to much pressure 😄 but now it seems to have lost transparency?

@morph166955
Copy link
Contributor Author

Not to put on to much pressure 😄 but now it seems to have lost transparency?

LOL I am not a graphics person. I just threw the original into paint and said "resize". No clue how to even attempt to do that.

@Hilbrand
Copy link
Member

Hilbrand commented Feb 3, 2023

I've created a transparent version (tried to do this via GitHub editor, but that creates a new pr. And I can't seem to create a pull request here to your branch). But the file is here: https://github.com/Hilbrand/openhab-docs/blob/eb77ffc885a51614f09099500b5d6ccc4452defa/images/addons/androidtv.png

Signed-off-by: Ben Rosenblum <[email protected]>
@morph166955
Copy link
Contributor Author

Thank you! I've committed the one you posted.

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍🏼

@Confectrician Confectrician merged commit 087d01a into openhab:main Feb 6, 2023
@morph166955 morph166955 deleted the androidtv branch February 6, 2023 13:49
@Confectrician Confectrician added this to the 4.0 milestone Mar 5, 2023
@maniac103
Copy link
Contributor

Given openhab/openhab-addons#14282 isn't merged (yet?), wasn't adding the icon a bit premature?

@Confectrician
Copy link
Contributor

Don't know how this happened.
I have no strong opinion on keeping or reverting this.
Hopefully it gets merged befor the 4.0 Release so we can simply save double work and leave it as is.

It won't break anything.

@morph166955
Copy link
Contributor Author

It is my sincere hope that the binding is merged into 4.0. It's just pending the review cycle at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants