-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add androidtv logo #2001
add androidtv logo #2001
Conversation
Signed-off-by: Ben Rosenblum <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site settings. |
Looks like the logo is larger than the required 512x512. See; https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website |
Signed-off-by: Ben Rosenblum <[email protected]>
Sorry, fixed now. Thank you! |
Not to put on to much pressure 😄 but now it seems to have lost transparency? |
LOL I am not a graphics person. I just threw the original into paint and said "resize". No clue how to even attempt to do that. |
I've created a transparent version (tried to do this via GitHub editor, but that creates a new pr. And I can't seem to create a pull request here to your branch). But the file is here: https://github.com/Hilbrand/openhab-docs/blob/eb77ffc885a51614f09099500b5d6ccc4452defa/images/addons/androidtv.png |
Signed-off-by: Ben Rosenblum <[email protected]>
Thank you! I've committed the one you posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. 👍🏼
Given openhab/openhab-addons#14282 isn't merged (yet?), wasn't adding the icon a bit premature? |
Don't know how this happened. It won't break anything. |
It is my sincere hope that the binding is merged into 4.0. It's just pending the review cycle at this point. |
Add logo for the new androidtv binding: openhab/openhab-addons#14282
Signed-off-by: Ben Rosenblum [email protected]