-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong negation #2323
Fix wrong negation #2323
Conversation
Signed-off-by: Felix Schneider <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the contribution, but I believe the original text is not incorrect. It explains itself in the next sentence clause. I agree though that the whole sentence is a bit nebulous but I guess it's kind of an introduction to what an Item is. |
I kind of understand where Felix is coming from.
How about phrasing it like that?
|
How about this? (Just remove the confusing part)
|
My suggestion would be to simply delete lines 15-18 completely. They don't give you information that isn't already explained further down. All they seem to do is add "noise" and confusion in your mind as you read through, especially if you are coming from a "blank canvas" not knowing anything about Items. The actual knowledge about items will be built up by reading through the subsequent paragraphs which do provide actual and practical information about what Items are and what they do. |
I agree 👍🏻 |
Me too, do you change the PR accordingly? |
Done |
I am pretty sure this
not
is/was wrong. If not what is an item instead?