Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong negation #2323

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Fix wrong negation #2323

merged 3 commits into from
Jul 20, 2024

Conversation

felixschndr
Copy link
Contributor

I am pretty sure this not is/was wrong. If not what is an item instead?

Signed-off-by: Felix Schneider <[email protected]>
Copy link

netlify bot commented Jun 27, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 951a03a
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6698098f1ccf6900088c33b8
😎 Deploy Preview https://deploy-preview-2323--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jimtng
Copy link
Contributor

jimtng commented Jul 15, 2024

Thanks for the contribution, but I believe the original text is not incorrect. It explains itself in the next sentence clause. I agree though that the whole sentence is a bit nebulous but I guess it's kind of an introduction to what an Item is.

@stefan-hoehn
Copy link
Contributor

I kind of understand where Felix is coming from.

An Item does not simply store information that is set by software (e.g., OFF, 3.141 or "No Error"); the information stored by an Item may also be set by actions that take place in your home.

How about phrasing it like that?

An Item does not simply store information that is set by software (e.g., OFF, 3.141 or "No Error") but rather information that is set by actions that take place in your home.

@felixschndr
Copy link
Contributor Author

How about this? (Just remove the confusing part)

An Item does store information that is set by actions that take place in your home (e.g., OFF, 3.141 or No Error).

@jimtng
Copy link
Contributor

jimtng commented Jul 17, 2024

My suggestion would be to simply delete lines 15-18 completely. They don't give you information that isn't already explained further down. All they seem to do is add "noise" and confusion in your mind as you read through, especially if you are coming from a "blank canvas" not knowing anything about Items.

The actual knowledge about items will be built up by reading through the subsequent paragraphs which do provide actual and practical information about what Items are and what they do.

@felixschndr
Copy link
Contributor Author

My suggestion would be to simply delete lines 15-18 completely. They don't give you information that isn't already explained further down. All they seem to do is add "noise" and confusion in your mind as you read through, especially if you are coming from a "blank canvas" not knowing anything about Items.

The actual knowledge about items will be built up by reading through the subsequent paragraphs which do provide actual and practical information about what Items are and what they do.

I agree 👍🏻

@stefan-hoehn
Copy link
Contributor

Me too, do you change the PR accordingly?

@felixschndr
Copy link
Contributor Author

Done

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Jul 20, 2024
@stefan-hoehn stefan-hoehn merged commit 18f77f6 into openhab:main Jul 20, 2024
5 checks passed
@felixschndr felixschndr deleted the patch-1 branch July 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants