Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence exclude documentation #2423

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Dec 8, 2024

Copy link

netlify bot commented Dec 8, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit a4e71b8
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/676017caa96178000873fab3
😎 Deploy Preview https://deploy-preview-2423--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the typo, LGTM thanks!
Good that you described the operator-precedence by pointing out "will be excluded after all additive rules have been applied".

The entries are additive.
This means if one Item appears in more than one `<itemlist>` either directly or indirectly (e.g. `*` which includes all Items or as a member of a Group used in `<groupName>*`), all the strategies strategies listed on all those lines apply to that Item.
In the same way, an Item defined by a `!<itemName>` or `!<groupName>*` will be excluded after all addititive rules have been applied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the same way, an Item defined by a `!<itemName>` or `!<groupName>*` will be excluded after all addititive rules have been applied.
In the same way, an Item defined by a `!<itemName>` or `!<groupName>*` will be excluded after all additive rules have been applied.

@mherwege
Copy link
Contributor Author

This functionality is available in 4.3. Can this be merged?

Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege force-pushed the persistence_exclude branch from 935ab31 to a4e71b8 Compare December 16, 2024 12:06
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Dec 16, 2024
@stefan-hoehn stefan-hoehn merged commit d3ff431 into openhab:main Dec 16, 2024
5 checks passed
@mherwege mherwege deleted the persistence_exclude branch December 16, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants