Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903931: Add "jtreg.ttf" property to filter tests based on test thread factory value #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jan 14, 2025

jtreg support test thread factory parameter that allows to execute tests by running main in virtual thread.

Currently, all incompatible tests are problemlisted. However after security manager removal the number of such tests is small.

So is it makes sense to add "jtreg.ttf" property to filter tests based on test thread factory value to allow filter out incompatible tests.

The only jtreg knows if -testThreadFactory is set so it should set corresponding property


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • CODETOOLS-7903931: Add "jtreg.ttf" property to filter tests based on test thread factory value (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/242/head:pull/242
$ git checkout pull/242

Update a local copy of the PR:
$ git checkout pull/242
$ git pull https://git.openjdk.org/jtreg.git pull/242/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 242

View PR using the GUI difftool:
$ git pr show -t 242

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/242.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 14, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant