Fix the bug in the Material.from_xml_element function #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cn-skywalker
changed the title
cn-skywalker
changed the title
cn-skywalker
changed the title
paulromano
approved these changes
Jan 28, 2025
ahnaf-tahmid-chowdhury
pushed a commit
to ahnaf-tahmid-chowdhury/OpenMC
that referenced
this pull request
Feb 6, 2025
Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the error in the Material.from_xml_element function that occurred while reading the depletable attribute from the XML file.
In the original function, the script performed a forced boolean conversion on the depletable attribute in the XML, but since the value of the depletable attribute is usually a string, regardless of what the value of the depletable attribute is, it will ultimately be converted to True (even if depletable=“false” is set). This is clearly a bug. Now this bug has been fixed in this PR.
Checklist
[√] I have performed a self-review of my own code
[√] I have added tests that prove my fix is effective or that my feature works (if applicable)