META-268: Enabled saving Term-B before importing ConceptReferenceTerm… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Nov 11, 2019
| @@ -42,6 +42,9 @@ public int getPriority() { | |||
| if (object.getConceptSource() != null) { | |||
| result.add(object.getConceptSource()); | |||
| } | |||
| if(object.getConceptReferenceTermMaps() !=null) { | |||
There was a problem hiding this comment.
Can you put space between != and null?
|
Can you also write a unit test for this using the data attached on the ticket? |
|
@reagan-meant did you see the above comments? |
|
Let me work on it... |
reagan-meant
force-pushed
the
META-268
branch
from
52e888e to
01e9d76
Compare
dkayiwa
reviewed
Jan 9, 2022
| public static final String CONCEPT_REFERENCE_TERMS_METADATA = "mds-concept-reference-terms-metadata.xml"; | ||
|
|
||
| private String headerXml; | ||
|
|
There was a problem hiding this comment.
Do you have any reason as to why these are class level instead of local variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
META-268: Enabled saving Term-B before importing ConceptReferenceTermMaps
https://issues.openmrs.org/browse/META-268