Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell type annotation: Harmony/KNN workflow #836

Open
wants to merge 66 commits into
base: main
Choose a base branch
from

Conversation

dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Jul 12, 2024

Changelog

PR #960 and #959 need to be merged first!
Workflow for harmony integration followed by KNN label transfer for cell type annotation.

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@dorien-er dorien-er changed the title Harmony knn annoation workflow Harmony knn annotation workflow Jul 12, 2024
VladimirShitov and others added 24 commits July 15, 2024 15:08
* cellranger mkgtf component working and tested

* removed comments

* changelog entry added

* test unique attribute in result

* multiple attribute par added

* removed unused packages

* use pytest, multiple attributes tested

---------

Co-authored-by: DriesSchaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
* cellranger mkgtf component working and tested

* removed comments

* changelog entry added

* test unique attribute in result

* multiple attribute par added

* removed unused packages

* use pytest, multiple attributes tested

---------

Co-authored-by: DriesSchaumont <[email protected]>
@dorien-er dorien-er force-pushed the harmony-knn-annoation-workflow branch from 6bcfac3 to e2049f1 Compare July 15, 2024 13:20
@DriesSchaumont DriesSchaumont self-assigned this Dec 26, 2024
@DriesSchaumont DriesSchaumont added this to the 2.1.0 milestone Jan 10, 2025
Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I will probably need to have a look at #948 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants