Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/maps allow excluding map IDs/UIDs #20

Closed
wants to merge 1 commit into from
Closed

core/maps allow excluding map IDs/UIDs #20

wants to merge 1 commit into from

Conversation

ezio416
Copy link
Contributor

@ezio416 ezio416 commented Apr 11, 2024

No description provided.

@codecat
Copy link
Member

codecat commented Apr 11, 2024

Shouldn't this be a different endpoint? Why should this be on this page?

@davidbmaier
Copy link
Member

Ye, probably best to split this into two endpoints since the routes are different. We have a similar situation in the Live API, makes sense to keep it consistent here imo.

codecat
codecat requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@codecat codecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be its own endpoint page.

@davidbmaier
Copy link
Member

Done in 87a78c8

@davidbmaier davidbmaier closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecat codecat codecat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezio416 @codecat @davidbmaier