Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activities.md #23

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Update activities.md #23

merged 2 commits into from
Sep 28, 2024

Conversation

ezio416
Copy link
Contributor

@ezio416 ezio416 commented Sep 28, 2024

remark on active param

remark on `active` param
@codecat
Copy link
Member

codecat commented Sep 28, 2024

Should we say:

Therefore, if you would like to see all enabled [..]

To make it a bit clearer?

@davidbmaier
Copy link
Member

davidbmaier commented Sep 28, 2024

I just tested it, and I think the original assumption is incorrect (or has changed since the first iteration of this page was written) - I can just omit the active parameter, and I get all activities (active and inactive).

So instead of these proposed changes, we should make the parameter optional and explain that omitting it means you'll get both enabled and disabled activities (as long as you're a club admin, otherwise you just get an error because you need to restrict it to active ones).

I made those changes in your branch @ezio416, but I'll keep this PR open for you to have a look as well in case I missed something.

@ezio416
Copy link
Contributor Author

ezio416 commented Sep 28, 2024

Thank you, I had not tried omitting the param and had gotten myself confused while trying to get activities for my own club and getting none. I think your change is worded nicely and clearly

@ezio416 ezio416 closed this Sep 28, 2024
@davidbmaier davidbmaier reopened this Sep 28, 2024
@davidbmaier davidbmaier merged commit ff3b745 into openplanet-nl:main Sep 28, 2024
1 of 2 checks passed
@ezio416 ezio416 deleted the patch-1 branch September 28, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants