Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exit codes helper file #26

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add exit codes helper file #26

merged 2 commits into from
Jan 15, 2025

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Jan 14, 2025

Describe your changes

Add a helper for raising exit code 99 when a method is not applicable to a dataset and use this in foundation model methods

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood January 14, 2025 08:35
rcannood
rcannood approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@lazappi lazappi merged commit 363df4d into main Jan 15, 2025
6 checks passed
lazappi added a commit that referenced this pull request Jan 15, 2025
@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-sc…
ad07a22 
…GPT-finetuned

* origin/main:
  Pin scPRINT version (#25)
  Increase UCE memory tag (#24)
  Add exit codes helper file (#26)
  Include all features in solution (#28)
  Update common submodule (#29)
lazappi added a commit that referenced this pull request Jan 16, 2025
@lazappi
Merge remote-tracking branch 'origin/main' into bugfix/no-ref/adjust-…
6e61f08 
…resources

* origin/main:
  Bump scIB to v1.1.7 (#30)
  Pin scPRINT version (#25)
  Increase UCE memory tag (#24)
  Add exit codes helper file (#26)
  Include all features in solution (#28)
  Update common submodule (#29)
@rcannood rcannood deleted the bugfix/no-ref/add-na-exit-code branch January 17, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood