Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments based on benchmark run #39

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Jan 21, 2025

Describe your changes

  • Add veryhighmem tag to kbet
  • Add exit code 99 to scgpt_finetuned for non-applicable datasets
  • Add the midsharedmem tag to scprint
  • Add the hightime tag to isolated_label_asw adn asw_label
  • Update the common submodule to commit b60eda0
  • Add arguments to scprint and enable tests
  • Handle multiprocessing errors and retry with single core in geneformer

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood January 21, 2025 11:57
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lazappi lazappi merged commit 01bdb9d into main Jan 21, 2025
36 checks passed
@lazappi lazappi deleted the bugfix/no-ref/run-adjustments branch January 21, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants