Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grouping bottleneck #42

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Jan 21, 2025

Describe your changes

Remove a bottleneck in the benchmark workflow caused by grouping clustering results that prevented metrics from running until all methods were complete

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ran the workflow locally on the test data and it works, LGTM!

@lazappi lazappi merged commit 624d849 into main Jan 21, 2025
2 checks passed
@rcannood rcannood deleted the bugfix/no-ref/avoid-grouping-bottleneck branch January 21, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants