Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare task for adding foundation models #24

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Prepare task for adding foundation models #24

merged 9 commits into from
Dec 9, 2024

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Nov 27, 2024 •
edited
Loading

Describe your changes

  • Update the common submodule
  • Use checkItemAllowed() for the method check in the benchmark workflow
  • Replace the cxg_mouse_pancreas_atlas with the cxg_immune_cell_atlas test dataset
  • Update README
  • Add a base method API schema

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood November 27, 2024 12:56
@lazappi lazappi mentioned this pull request Nov 28, 2024
Merged
8 tasks
rcannood
rcannood approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 9c77313 into main Dec 9, 2024
12 checks passed
@rcannood rcannood deleted the prepare-task branch December 9, 2024 12:40
lazappi added a commit that referenced this pull request Dec 10, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-sc…
9ac0246 
…PRINT

* origin/main:
  Prepare task for adding foundation models (#24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood