Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust waypoint distances #14

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Dec 18, 2024

Describe your changes

  • Only use distances between waypoint cells instead of between all cells and waypoints.
  • Increase the number of waypoints to 50000

Fixes #13

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood December 18, 2024 15:28
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor suggestions to call this 0.2.0 since there isn't a 0.2.0 release yet

* Modify co-ranking metrics to use pre-computed distances (PR #11)
* Modify distance correlation metrics to use pre-computed distances (PR #11)
* Move spectral distance correlation to a separate component (PR #11)
* Disable the trustworthiness metric as it is calculated as part of the co-ranking metrics (PR #11)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Only calculate distances between waypoint cells instead of between all cells and waypoint cells (PR #14)
* Only calculate distances between waypoint cells and label centroids instead of all cells and label centroids (PR #14)
* Use between waypoint distances instead of cell-waypoint distances and waypoint-centroid distances instead of cell-centroid distances in distance correlation metrics (PR #14)

CHANGELOG.md Outdated
Comment on lines 24 to 32
# dimensionality_reduction 0.2.1 2024-12-18

## MAJOR CHANGES

* Only calculate distances between waypoint cells instead of between all cells and waypoint cells (PR #14)
* Only calculate distances between waypoint cells and label centroids instead of all cells and label centroids (PR #14)
* Use between waypoint distances instead of cell-waypoint distances and waypoint-centroid distances instead of cell-centroid distances in distance correlation metrics (PR #14)

# dimensionality_reduction 0.2.0 2024-12-09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# dimensionality_reduction 0.2.1 2024-12-18
## MAJOR CHANGES
* Only calculate distances between waypoint cells instead of between all cells and waypoint cells (PR #14)
* Only calculate distances between waypoint cells and label centroids instead of all cells and label centroids (PR #14)
* Use between waypoint distances instead of cell-waypoint distances and waypoint-centroid distances instead of cell-centroid distances in distance correlation metrics (PR #14)
# dimensionality_reduction 0.2.0 2024-12-09
# dimensionality_reduction 0.2.0 2024-12-19

@lazappi lazappi merged commit 575355a into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only compute distances between waypoints
2 participants