Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #4

Merged
merged 5 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions _viash.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,10 @@ info:
dest: resources_test/task_predict_modality

repositories:
- name: openproblems_v2
- name: openproblems
type: github
repo: openproblems-bio/openproblems-v2
repo: openproblems-bio/openproblems
tag: main_build
- name: core
type: github
repo: openproblems-bio/core
# tag: build/main
tag: build/add_common_components
path: viash/core

config_mods: |
.runners[.type == "nextflow"].config.labels := { lowmem : "memory = 20.Gb", midmem : "memory = 50.Gb", highmem : "memory = 100.Gb", lowcpu : "cpus = 5", midcpu : "cpus = 15", highcpu : "cpus = 30", lowtime : "time = 1.h", midtime : "time = 4.h", hightime : "time = 8.h", veryhightime : "time = 24.h" }
2 changes: 1 addition & 1 deletion scripts/create_datasets/resources.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ tw launch https://github.com/openproblems-bio/task_predict_modality.git \
--pull-latest \
--main-script target/nextflow/workflows/process_datasets/main.nf \
--workspace 53907369739130 \
--compute-env 6TeIFgV5OY4pJCk8I0bfOh \
--compute-env 5DwwhQoBi0knMSGcwThnlF \
--params-file /tmp/params.yaml \
--entry-name auto \
--config common/nextflow_helpers/labels_tw.config \
Expand Down
6 changes: 3 additions & 3 deletions scripts/run_benchmark/run_full_seqeracloud.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ publish_dir="s3://openproblems-data/resources/task_predict_modality/results/${RU

# write the parameters to file
cat > /tmp/params.yaml << HERE
input_states: s3://openproblems-data/resources/task_predict_modality/datasets/**/state.yaml
rename_keys: 'input_train_mod1:output_train_mod1;input_train_mod2:output_train_mod2;input_test_mod1:output_test_mod1;input_test_mod2:output_test_mod2"
input_states: "s3://openproblems-data/resources/task_predict_modality/datasets/**/state.yaml"
rename_keys: "input_train_mod1:output_train_mod1;input_train_mod2:output_train_mod2;input_test_mod1:output_test_mod1;input_test_mod2:output_test_mod2"
output_state: "state.yaml"
publish_dir: "$publish_dir"
HERE
Expand All @@ -25,7 +25,7 @@ tw launch https://github.com/openproblems-bio/task_predict_modality.git \
--pull-latest \
--main-script target/nextflow/workflows/run_benchmark/main.nf \
--workspace 53907369739130 \
--compute-env 6TeIFgV5OY4pJCk8I0bfOh \
--compute-env 5DwwhQoBi0knMSGcwThnlF \
--params-file /tmp/params.yaml \
--entry-name auto \
--config common/nextflow_helpers/labels_tw.config \
Expand Down
2 changes: 1 addition & 1 deletion scripts/run_benchmark/run_test_seqeracloud.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ tw launch https://github.com/openproblems-bio/task_predict_modality.git \
--pull-latest \
--main-script target/nextflow/workflows/run_benchmark/main.nf \
--workspace 53907369739130 \
--compute-env 6TeIFgV5OY4pJCk8I0bfOh \
--compute-env 5DwwhQoBi0knMSGcwThnlF \
--params-file /tmp/params.yaml \
--config common/nextflow_helpers/labels_tw.config \
--labels task_predict_modality,test
2 changes: 1 addition & 1 deletion src/control_methods/mean_per_gene/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ runners:
- type: executable
- type: nextflow
directives:
label: [midtime, lowmem, lowcpu]
label: [midtime, midmem, lowcpu]

2 changes: 1 addition & 1 deletion src/control_methods/random_predict/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ runners:
- type: executable
- type: nextflow
directives:
label: [midtime, lowmem, lowcpu]
label: [midtime, midmem, lowcpu]
2 changes: 1 addition & 1 deletion src/control_methods/solution/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ runners:
- type: executable
- type: nextflow
directives:
label: [midtime, lowmem, lowcpu]
label: [midtime, midmem, lowcpu]
2 changes: 1 addition & 1 deletion src/control_methods/zeros/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ runners:
- type: executable
- type: nextflow
directives:
label: [midtime, lowmem, lowcpu]
label: [midtime, midmem, lowcpu]
2 changes: 1 addition & 1 deletion src/methods/knnr_py/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ runners:
- type: executable
- type: nextflow
directives:
label: [hightime, lowmem, lowcpu]
label: [hightime, midmem, midcpu]
2 changes: 1 addition & 1 deletion src/methods/knnr_r/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ runners:
- type: executable
- type: nextflow
directives:
label: [hightime, lowmem, lowcpu]
label: [hightime, midmem, midcpu]
8 changes: 4 additions & 4 deletions src/workflows/process_datasets/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ resources:
entrypoint: run_wf
- path: /common/nextflow_helpers/helper.nf
dependencies:
- name: schema/verify_data_structure
repository: core
- name: h5ad/extract_uns_metadata
repository: core
- name: validation/check_dataset_with_schema
repository: openproblems
- name: utils/extract_uns_metadata
repository: openproblems
- name: data_processors/process_dataset
runners:
- type: nextflow
8 changes: 4 additions & 4 deletions src/workflows/process_datasets/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ workflow run_wf {
output_ch = input_ch

// Check if the input datasets match the desired format --------------------------------
| verify_data_structure.run(
key: "verify_data_structure_mod1",
| check_dataset_with_schema.run(
key: "check_dataset_with_schema_mod1",
fromState: { id, state ->
def schema = findArgumentSchema(meta.config, "input_mod1")
def schemaYaml = tempFile("schema.yaml")
Expand All @@ -36,8 +36,8 @@ workflow run_wf {
}
)

| verify_data_structure.run(
key: "verify_data_structure_mod2",
| check_dataset_with_schema.run(
key: "check_dataset_with_schema_mod2",
fromState: { id, state ->
def schema = findArgumentSchema(meta.config, "input_mod2")
def schemaYaml = tempFile("schema.yaml")
Expand Down
4 changes: 2 additions & 2 deletions src/workflows/run_benchmark/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ resources:
- type: file
path: /_viash.yaml
dependencies:
- name: h5ad/extract_uns_metadata
repository: core
- name: utils/extract_uns_metadata
repository: openproblems
- name: control_methods/mean_per_gene
- name: control_methods/random_predict
- name: control_methods/zeros
Expand Down