Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change results hero #181

Merged
merged 2 commits into from
Mar 14, 2023
Merged

change results hero #181

merged 2 commits into from
Mar 14, 2023

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Mar 13, 2023

Describe your changes

New proposal for the results hero using a 3d render of the dynverse funkyheatmap made by @zouter (and me, a little bit).

→→ Preview link ←←

Issue ticket number and link

Closes #141

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Minor changes
  • Proposed changes are described in the CHANGELOG.md

  • CI Preview succeeds and looks good!

@github-actions
Copy link

Deploy: success

Copy link
Contributor

@KaiWaldrant KaiWaldrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every time I look at it, I like it more and more. Maybe if the colors were more like a 'pastel' color it would blend more with the website ? I feel like the contrast is too big ? can't just put my finger on it. In essence I like it more then all the other suggestions

@scottgigante-immunai
Copy link
Collaborator

I agree, this is a big improvement. I think Kai is right though that it would be better if the colours (particularly the blue and the green) were more pastel.

@rcannood
Copy link
Member Author

The colour schemes used for the vertical bars are, at this moment, the same as the ones used by default in the funkyheatmap. I'm happy to change them to a more pastel colour, but it requires recreating the blender model.

@scottgigante-immunai If this is a big improvement, how about we merge this branch and create a github issue for the follow up changes? (Or simply reuse #141)

@scottgigante
Copy link
Contributor

Works for me.

@scottgigante scottgigante merged commit b5af67c into main Mar 14, 2023
@rcannood rcannood deleted the theme/alternative_results_hero branch March 22, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change benchmarks hero
4 participants