Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset links and semantic changes #362

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

KaiWaldrant
Copy link
Contributor

@KaiWaldrant KaiWaldrant commented Nov 4, 2024

Describe your changes

  • Added url to the benchmark datasets that link to the dataset page
  • Add "n cells x m genes" to datasetinfo instead of "n x m"
  • Fix used in links on the datasets details pages

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Preview succeeds and looks good!

@KaiWaldrant KaiWaldrant requested a review from rcannood November 4, 2024 19:18
Copy link

github-actions bot commented Nov 4, 2024

Deploy: success

@KaiWaldrant
Copy link
Contributor Author

Noticed an issue with datasets in spatial decomposition. It lists DESTVI but is not submitted to the datasets pages because this is a simulated dataset. https://feature-no-ref-add-dataset-return-link--openproblems.netlify.app/results/spatial_decomposition/#dataset-info

@rcannood
Copy link
Member

rcannood commented Nov 6, 2024

I also notice that for this dataset

https://feature-no-ref-add-dataset-return-link--openproblems.netlify.app/datasets/tenx_visium/post_xenium/human_colon_cancer/

The "Used in" link isn't working. I can imagine why this is, but could you take a look?

@rcannood
Copy link
Member

rcannood commented Nov 6, 2024

Noticed an issue with datasets in spatial decomposition. It lists DESTVI but is not submitted to the datasets pages because this is a simulated dataset. https://feature-no-ref-add-dataset-return-link--openproblems.netlify.app/results/spatial_decomposition/#dataset-info

Is it possible to only add a link if that dataset exists?

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comments ^^

@KaiWaldrant KaiWaldrant requested a review from rcannood November 6, 2024 14:06
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 446ea90 into main Nov 6, 2024
1 check passed
@rcannood rcannood deleted the feature/no-ref/add-dataset-return-link branch November 29, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants