Add method parameters alignment, fixes to spaces visitor, and extended end2end tests #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdebruin
added
bug
Comment on lines
+144
to
+146
| def_idx = source.index("def") | ||
| async_idx = source.find("async") | ||
| start_idx = async_idx if async_idx != -1 and async_idx < def_idx else def_idx |
There was a problem hiding this comment.
I am a little bit worried that this could go wrong if there is a decorator or comment including the substring def or async somewhere. It would be safer if we in this FirstArgPrinter would detect when either of these keywords is written and store that in a variable.
There was a problem hiding this comment.
I am also wondering if this works correctly when for example a decorator is on the same line as the def keyword as in:
@decorator def my_function(a,
b):
passI suppose this would be easy to test.
There was a problem hiding this comment.
That is not valid Python (as far as I know)
| return self if align_multiline_parameters is self._align_multiline_parameters else replace(self, | ||
| _align_multiline_parameters=align_multiline_parameters) | ||
|
|
||
| _method_declaration_parameters: MethodDeclarationParameters |
There was a problem hiding this comment.
We need to make the same modification to the Java side, where we declare this style.
knutwannheden
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds alignment for method parameters and implements several fixes in the visitor of the space, particularly for imports, and extends the overall test-suite.
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@knutwannheden
Have you considered any alternatives or workarounds?
Any additional context
Checklist