Json formatting arrays #4936
Draft
Json formatting arrays #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng more cases in TabsAndIndentsVisitor
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+18
to
+19
| import org.jetbrains.annotations.NotNull; | ||
| import org.jspecify.annotations.Nullable; |
There was a problem hiding this comment.
Suggested change
| import org.jetbrains.annotations.NotNull; | |
| import org.jspecify.annotations.Nullable; | |
| import org.jspecify.annotations.Nullable; |
| return ret.getPadding().withValues(ensureCollectionHasNewLines(ret.getPadding().getValues())); | ||
| } | ||
|
|
||
| private static <J extends Json> @NotNull List<JsonRightPadded<J>> ensureCollectionHasNewLines(List<JsonRightPadded<J>> elements) { |
There was a problem hiding this comment.
Suggested change
| private static <J extends Json> @NotNull List<JsonRightPadded<J>> ensureCollectionHasNewLines(List<JsonRightPadded<J>> elements) { | |
| private static <J extends Json> List<JsonRightPadded<J>> ensureCollectionHasNewLines(List<JsonRightPadded<J>> elements) { |
Comment on lines
+18
to
19
| import org.jetbrains.annotations.NotNull; | ||
| import org.jspecify.annotations.Nullable; |
There was a problem hiding this comment.
Suggested change
| import org.jetbrains.annotations.NotNull; | |
| import org.jspecify.annotations.Nullable; | |
| import org.jspecify.annotations.Nullable; |
| for (int i = 0; i < indentMultiple; i++) { | ||
| if (style.getUseTabCharacter()) { | ||
| shiftedPrefixBuilder.append("\t"); | ||
| private static @NotNull <J extends Json> List<JsonRightPadded<J>> ensureCollectionHasIndents(List<JsonRightPadded<J>> elements, String relativeIndent) { |
There was a problem hiding this comment.
Suggested change
| private static @NotNull <J extends Json> List<JsonRightPadded<J>> ensureCollectionHasIndents(List<JsonRightPadded<J>> elements, String relativeIndent) { | |
| private static <J extends Json> List<JsonRightPadded<J>> ensureCollectionHasIndents(List<JsonRightPadded<J>> elements, String relativeIndent) { |
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "Indents JSON using the most common indentation size and tabs or space choice in use in the file."; |
There was a problem hiding this comment.
As this will be about more than indenting, we might want to make the description a bit more general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist