Cleanup #71
Merged
Cleanup #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to use all children, not just the first child.
…ransformations.scad to operate on all children.
…odule fromTo (didn't take time to fully understand), but no load/run errors.
…d error in test code: no $center parm for sphere().
…hould. Also made modules work on all childen, rather than only the first. Check spin() particulary, as I changed it the most.
…confirmed no other refs in MCAD files.
hyperair
reviewed
Mar 26, 2020
hyperair
approved these changes
Mar 26, 2020
Co-Authored-By: Chow Loong Jin <[email protected]>
Co-Authored-By: Chow Loong Jin <[email protected]>
|
I just checked, the Also, I parameterized to remove the Final change for the day... Thanks! |
hyperair
reviewed
Mar 27, 2020
| for (i = [0 : $children-1]) child(i); | ||
| } | ||
| } | ||
| // Copy everything $no of times around an $axis, spread over $angle |
There was a problem hiding this comment.
Variables can begin with $ in openscad, so don't use $no, $axis, et. al. to denote the no and axis parameters; it'll cause confusion in the future.
There was a problem hiding this comment.
Good call. I saw that in multiply.scad and thought I was following this library's format for comments. I'll work on another pull request to fix those comments in other files.
… indent tabs, and shorten for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the deprecated child() and assign() in the library. I also made a few changes while testing/validating my updates:
I tried to make the changes clear in each commit comment.
Thanks for a great library!