-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TESTID-116, TESTID-115, TESTID-61 - Tests for Saved Searches in Dashboard #9288
base: main
Are you sure you want to change the base?
TESTID-116, TESTID-115, TESTID-61 - Tests for Saved Searches in Dashboard #9288
Conversation
…STID-61 Signed-off-by: Justin Kim <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9288 +/- ##
==========================================
+ Coverage 61.70% 61.72% +0.01%
==========================================
Files 3816 3816
Lines 91824 91824
Branches 14542 14542
==========================================
+ Hits 56664 56674 +10
+ Misses 31506 31495 -11
- Partials 3654 3655 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cy.getElementByTestId('docTableField').should('be.visible'); | ||
|
||
// set a date where there should be no results | ||
setDatePickerDatesAndSearchIfRelevant( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets change to a valid time range where we have atleast some hits which is different from the expected hits in the config. That will ensure that changing time ranges actually updates the underlying search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sounds good. i'm a bit concerned though about timezone differences between my env and the CI/CD (or does that matter)? Lets see though, i'll push out a change that works on my end
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Description
Adds tests for Saved Searches in Dashboards: #8961 , #8960 , #8959
Issues Resolved
closes #8961
closes #8960
closes #8959
Changelog
Check List
yarn test:jest
yarn test:jest_integration