-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample-extension-plugin BWC version to 2.14.0 #609
Conversation
Signed-off-by: Prudhvi Godithi <[email protected]>
Adding @cwperks @joshpalis @dbwiddis to please check this. |
@prudhvigodithi Should this value be trailing by one minor version? If this is updated, the bwc tests would run with 2.14 -> 2.14. Is there a failing check? |
@cwperks thanks for checking this PR. I just followed the same way on how the bwc is managed for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Got it, thank you Prudhvi! This change LGTM. Should we look into implementing an automatic version increment for this? |
Yes @cwperks I'm planning to leverage the gradle updateVersion task for this, but I'm curious if we need this |
IMO the sample-extension-plugin is a good reference for plugin developers wanting to incorporate scheduled jobs in their plugins. They can use sample-extension-plugin as a reference on how to implement the JobSchedulerExtension extension point and how to use the locking service. |
Make sense, let me open an new issue and add more details on onboarding job-scheduler to integration testing pipeline and also in improving the code coverage. |
Description
Coming from the version increment PR 2.14.0 PR #605.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.