Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample-extension-plugin BWC version to 2.14.0 #609

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

prudhvigodithi
Copy link
Member

Description

Coming from the version increment PR 2.14.0 PR #605.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Member Author

Adding @cwperks @joshpalis @dbwiddis to please check this.
@bbarani

@cwperks
Copy link
Member

cwperks commented Apr 10, 2024

@prudhvigodithi Should this value be trailing by one minor version? If this is updated, the bwc tests would run with 2.14 -> 2.14.

Is there a failing check?

@prudhvigodithi
Copy link
Member Author

@cwperks thanks for checking this PR. I just followed the same way on how the bwc is managed for sample-extension-plugin, example #528. Since the 2.x is already incremented to 2.14.0 I have updated main (3.0.0) to 2.14.0.

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwperks
Copy link
Member

cwperks commented Apr 10, 2024

Got it, thank you Prudhvi! This change LGTM. Should we look into implementing an automatic version increment for this?

@prudhvigodithi
Copy link
Member Author

Yes @cwperks I'm planning to leverage the gradle updateVersion task for this, but I'm curious if we need this sample-extension-plugin once we have proper unit and integ tests added.

@cwperks
Copy link
Member

cwperks commented Apr 10, 2024

IMO the sample-extension-plugin is a good reference for plugin developers wanting to incorporate scheduled jobs in their plugins. They can use sample-extension-plugin as a reference on how to implement the JobSchedulerExtension extension point and how to use the locking service.

@prudhvigodithi
Copy link
Member Author

Make sense, let me open an new issue and add more details on onboarding job-scheduler to integration testing pipeline and also in improving the code coverage.

@prudhvigodithi prudhvigodithi merged commit 78150f2 into opensearch-project:main Apr 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants