Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML Controller APIs #779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nathaliellenaa
Copy link
Contributor

@nathaliellenaa nathaliellenaa commented Jan 10, 2025

Description

Added missing ML Controller APIs.

Issues Resolved

Part of opensearch-project/opensearch-py#867.

ML Controller APIs to add

  • POST /_plugins/_ml/controllers/{model_id}
  • PUT /_plugins/_ml/controllers/{model_id}
  • GET /_plugins/_ml/controllers/{model_id}
  • DELETE /_plugins/_ml/controllers/{model_id}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Changes Analysis

Commit SHA: aa51ade
Comparing To SHA: 9efddb9

API Changes

Summary

├─┬Paths
│ └──[➕] path (4817:3)
└─┬Components
  ├──[➕] requestBodies (28408:7)
  ├──[➕] requestBodies (27974:7)
  ├──[➕] responses (31814:7)
  ├──[➕] responses (31509:7)
  ├──[➕] responses (31568:7)
  ├──[➕] responses (31626:7)
  ├──[➕] parameters (23548:7)
  ├──[➕] parameters (23722:7)
  ├──[➕] parameters (23614:7)
  ├──[➕] parameters (23572:7)
  ├──[➕] schemas (56541:7)
  └──[➕] schemas (56522:7)

Document Element Total Changes Breaking Changes
paths 1 0
components 12 0
  • Total Changes: 13
  • Additions: 13

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12716275619/artifacts/2414931443

API Coverage

Before After Δ
Covered (%) 643 (62.98 %) 647 (63.37 %) 4 (0.39 %)
Uncovered (%) 378 (37.02 %) 374 (36.63 %) -4 (-0.39 %)
Unknown 43 43 0

@dblock
Copy link
Member

dblock commented Jan 10, 2025

Looks like there's a test failure, otherwise LGTM.

@nathaliellenaa
Copy link
Contributor Author

Looks like the failing test is due to the Memory Circuit Breaker flaky error https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12701647488/artifacts/2410641526. I made a fix for this issue in this PR and I can rerun the test once this PR has been merged.

@dblock
Copy link
Member

dblock commented Jan 10, 2025

Looks like the failing test is due to the Memory Circuit Breaker flaky error https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12701647488/artifacts/2410641526. I made a fix for this issue in this PR and I can rerun the test once this PR has been merged.

Merged, rebase?

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
577 574 (99.48 %)

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs folder got folded in, remove and add it to .gitignore?

Also check test coverage? We were at 100, we lost something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants