Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run AuthZ tests too as part of auth test suite #1060

Conversation

creydr
Copy link
Member

@creydr creydr commented Feb 5, 2025

As per title

/cherry-pick release-v1.17
/cherry-pick release-v1.16

@openshift-ci openshift-ci bot requested review from matzew and pierDipi February 5, 2025 12:44
@openshift-ci openshift-ci bot added the approved label Feb 5, 2025
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1fbaf8c into openshift-knative:main Feb 5, 2025
2 checks passed
@creydr
Copy link
Member Author

creydr commented Feb 5, 2025

/cherry-pick release-v1.17
/cherry-pick release-v1.16

@openshift-cherrypick-robot

@creydr: new pull request created: #1061

In response to this:

/cherry-pick release-v1.17
/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@creydr: new pull request created: #1062

In response to this:

As per title

/cherry-pick release-v1.17
/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@creydr: new pull request could not be created: failed to create pull request against openshift-knative/eventing#release-v1.16 from head openshift-cherrypick-robot:cherry-pick-1060-to-release-v1.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-1060-to-release-v1.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

As per title

/cherry-pick release-v1.17
/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@creydr: new pull request could not be created: failed to create pull request against openshift-knative/eventing#release-v1.17 from head openshift-cherrypick-robot:cherry-pick-1060-to-release-v1.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-1060-to-release-v1.17."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-v1.17
/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants