Add e2e for manualapprovalgate and chains #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
requested review from
openshift-pipelines-bot and
savitaashture
pramodbindal
changed the title
| - name: CHAINS_DOCKER_CONFIG_JSON | ||
| valueFrom: | ||
| secretKeyRef: | ||
| key: config.json |
There was a problem hiding this comment.
where do we create this secret ??
There was a problem hiding this comment.
I have created this manually. dont know if we need to put the code to create secret somewhere
There was a problem hiding this comment.
may be some instruction in doc how to create secret and what value it should have will be useful
pramodbindal
force-pushed
the
e2e-manualapprovalgate
branch
from
0bad8d9 to
ea08f42
Compare
Add environment variables for chains e2e Add e2e for manualapprovalgate Add Document for E2E configuration
pramodbindal
force-pushed
the
e2e-manualapprovalgate
branch
from
ea08f42 to
c21a5da
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pramodbindal, savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2e for manualapprovalgate