Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-629: Update modules to latest #817

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jstuever
Copy link
Contributor

No description provided.

Adding update-go-dependencies target to assist with updating all of the
go dependenceis on a regular basis. Calling this target will update all
of the go modules to their latest version, with exception of the k8s
modules due to them needing to be version specific.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2025

@jstuever: This pull request references CCO-629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom January 15, 2025 21:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@jstuever
Copy link
Contributor Author

Should run all of the tests on this one. Waiting to see how the defaults turn out.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.01%. Comparing base (6e5ca5b) to head (ba07733).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   47.01%   47.01%           
=======================================
  Files          97       97           
  Lines       11874    11874           
=======================================
  Hits         5583     5583           
  Misses       5676     5676           
  Partials      615      615           
Files with missing lines Coverage Δ
pkg/assets/bootstrap/bindata.go 23.85% <ø> (ø)

@jstuever
Copy link
Contributor Author

/test givemealist

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@jstuever: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test coverage
/test e2e-aws-ovn
/test e2e-azure-manual-oidc
/test e2e-hypershift
/test e2e-upgrade
/test images
/test security
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-manual-oidc
/test e2e-aws-qe
/test e2e-azure
/test e2e-azure-upgrade
/test e2e-gcp
/test e2e-gcp-manual-oidc
/test e2e-openstack
/test e2e-openstack-parallel
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cloud-credential-operator-master-coverage
pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
pull-ci-openshift-cloud-credential-operator-master-e2e-aws-qe
pull-ci-openshift-cloud-credential-operator-master-e2e-hypershift
pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
pull-ci-openshift-cloud-credential-operator-master-images
pull-ci-openshift-cloud-credential-operator-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-cloud-credential-operator-master-security
pull-ci-openshift-cloud-credential-operator-master-unit
pull-ci-openshift-cloud-credential-operator-master-verify
pull-ci-openshift-cloud-credential-operator-master-verify-deps

In response to this:

/test givemealist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstuever
Copy link
Contributor Author

/test e2e-azure-manual-oidc e2e-aws-manual-oidc e2e-azure e2e-azure-upgrade e2e-gcp e2e-gcp-manual-oidc e2e-openstack

@jstuever
Copy link
Contributor Author

/test e2e-hypershift

@jstuever
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor Author

/test ci/prow/e2e-gcp

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@jstuever: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test coverage
/test e2e-aws-ovn
/test e2e-azure-manual-oidc
/test e2e-hypershift
/test e2e-upgrade
/test images
/test security
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-manual-oidc
/test e2e-aws-qe
/test e2e-azure
/test e2e-azure-upgrade
/test e2e-gcp
/test e2e-gcp-manual-oidc
/test e2e-openstack
/test e2e-openstack-parallel
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cloud-credential-operator-master-coverage
pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
pull-ci-openshift-cloud-credential-operator-master-e2e-aws-qe
pull-ci-openshift-cloud-credential-operator-master-e2e-hypershift
pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
pull-ci-openshift-cloud-credential-operator-master-images
pull-ci-openshift-cloud-credential-operator-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-cloud-credential-operator-master-security
pull-ci-openshift-cloud-credential-operator-master-unit
pull-ci-openshift-cloud-credential-operator-master-verify
pull-ci-openshift-cloud-credential-operator-master-verify-deps

In response to this:

/test ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstuever
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstuever
Copy link
Contributor Author

/assign @dlom

@dlom
Copy link
Contributor

dlom commented Jan 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants