NO-JIRA: fix: resolve some integration tests

[eggfoobar]

There are three issues that are currently the reason for the integration tests failing

1. errors do not come back in lexical order so the match fails
2. status controller does not use mom timestamp to timestamps do not match
3. certs get generated differently between runs so certs do not match

This PR pulls in the a latest from library-go and resolves number 1 and number 2.

/hold

We'll need to wait for openshift/library-go#1916 to be merged in.

[openshift-ci-robot]

@eggfoobar: This pull request explicitly references no jira issue.

In response to this:

library-go has been updated to sort errors for consistent output during testing updating order to make use of it

/hold

We'll need to wait for openshift/library-go#1916 to be merged in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

/unhold

Library-go has been updated, this PR will only resolve issue 1 and 2, integration tests will still fail but now we only fail on cert mismatch

Latest Run

{expected results mismatch 2 times with actual results  Management: mutation: Create-Secret.v1./v4-0-config-system-session[openshift-authentication], fieldManager=, controllerInstanceName=, rhs[0]: body diff:   []uint8(
  	"""
  	apiVersion: v1
  	data:
- 	  v4-0-config-system-session: eyJraW5kIjoiU2Vzc2lvblNlY3JldHMiLCJhcGlWZXJzaW9uIjoib3BlcmF0b3J2MWNsaWVudCIsInNlY3JldHMiOlt7ImF1dGhlbnRpY2F0aW9uIjoiZXlFUDNvR21XNnNEdW5JWlV2aHVabFJXV25GdlpkQ2RhYXJCZGl0MEJ2b1FKOVp2aW8xcHdNMUdDNXF6RTY2NyIsImVuY3J5cHRpb24iOiJmSDNqeF9CR0J0alBZQW9HU011M3RJbVpLX29aRmdWeiJ9XX0=
+ 	  v4-0-config-system-session: eyJraW5kIjoiU2Vzc2lvblNlY3JldHMiLCJhcGlWZXJzaW9uIjoib3BlcmF0b3J2MWNsaWVudCIsInNlY3JldHMiOlt7ImF1dGhlbnRpY2F0aW9uIjoiQk9kUzl5T0trX0szSkRxM05kZFdxVDd4Nm5VVy1hOWRkUWh3cENiZ0RmaUNEOGVqbUhjdjZVOEpDZURRNEYxQSIsImVuY3J5cHRpb24iOiJBN282eGV0c1hCcWhiM2lwN2N3T3pPazd6M2dEbUZ1XyJ9XX0=
  	kind: Secret
  	metadata:
  	... // 6 identical lines
  	"""
  )

UserWorkload: mutation: Create-CertificateSigningRequest.v1.certificates.k8s.io/system:openshift:openshift-authenticator-[], fieldManager=, controllerInstanceName=, rhs[0]: body diff:   []uint8(
  	"""
  	... // 6 identical lines
  	    authentication.openshift.io/csr: openshift-authenticator
  	spec:
- 	  request: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURSBSRVFVRVNULS0tLS0KTUlJQkRqQ0J0QUlCQURCU01WQXdUZ1lEVlFRREUwZHplWE4wWlcwNmMyVnlkbWxqWldGalkyOTFiblE2YjNCbApibk5vYVdaMExXOWhkWFJvTFdGd2FYTmxjblpsY2pwdmNHVnVjMmhwWm5RdFlYVjBhR1Z1ZEdsallYUnZjakJaCk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQkx6Q3hKUTRjZ2tubVlqdytSd1Nmb2kwUWt5dktua1UKOEZuUXJJRWxNUE8vUG13eDdva1h5SjhONmNpQkNZaWYrLzkvaTdIN1MzN3BrUkM5YmliRnQvU2dBREFLQmdncQpoa2pPUFFRREFnTkpBREJHQWlFQTJjRXRhbHczWENSMlhkODZGN2tsL2hzWWlKNTZYMlBWcXVnUHA5SGxwWjhDCklRRElxR25WcE5wbXRPMWlYazFJaGhxWlVsbGZ5YmxHS3F6U0VhWWFRTEhRUXc9PQotLS0tLUVORCBDRVJUSUZJQ0FURSBSRVFVRVNULS0tLS0K
+ 	  request: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURSBSRVFVRVNULS0tLS0KTUlJQkRqQ0J0QUlCQURCU01WQXdUZ1lEVlFRREUwZHplWE4wWlcwNmMyVnlkbWxqWldGalkyOTFiblE2YjNCbApibk5vYVdaMExXOWhkWFJvTFdGd2FYTmxjblpsY2pwdmNHVnVjMmhwWm5RdFlYVjBhR1Z1ZEdsallYUnZjakJaCk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQlBKVytpMmlwcFVtakh0YjVjYWRBM0hIRUJhT2ViQUkKNVRoUG1HOUxsWHFMeVlvNWFSbGsxM1NEUXRUVWNiTmExVGtrRVJESjRmOVEyaHJkS2RNSHFFeWdBREFLQmdncQpoa2pPUFFRREFnTkpBREJHQWlFQXhyME1HangwMUhMbE5TMXJDWkxsMTJCUXJNUEtyQ2dZODlWcWxDWkxwZThDCklRQzZ4M05meXlneTRWUklhZklPblBWVnFQVTdWZ2NPRXA1ZEY2ZGhOS3B4aHc9PQotLS0tLUVORCBDRVJUSUZJQ0FURSBSRVFVRVNULS0tLS0K
  	  signerName: kubernetes.io/kube-apiserver-client
  	  usages:
  	... // 5 identical lines
  	"""
  )
}

[deads2k]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ca163e0 and 2 for PR HEAD b906a10 in total

[eggfoobar]

/retest-required

[openshift-ci]

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	b906a10	link	true	/test e2e-operator
ci/prow/e2e-agnostic-upgrade	b906a10	link	true	/test e2e-agnostic-upgrade
ci/prow/e2e-agnostic	b906a10	link	true	/test e2e-agnostic
ci/prow/test-operator-integration	b906a10	link	false	/test test-operator-integration
ci/prow/e2e-agnostic-ipv6	b906a10	link	false	/test e2e-agnostic-ipv6
ci/prow/okd-scos-e2e-aws-ovn	b906a10	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-console-login	b906a10	link	true	/test e2e-console-login

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.