Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MON-1850] Replace bearer token by client TLS certificate for metrics scraping #1392

Merged
merged 4 commits into from
Oct 20, 2021
Merged

[MON-1850] Replace bearer token by client TLS certificate for metrics scraping #1392

merged 4 commits into from
Oct 20, 2021

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Sep 21, 2021 •
edited
Loading

Remove bearer token from service monitors and use TLS certificate for authentication + authorization.
This PR is complete now, with PR#1406 and PR#1411, this issue will be fully resolved.
Progress:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@raptorsun raptorsun force-pushed the feature/MON-1850 branch 2 times, most recently from 3809dbc to 21a8151 Compare September 24, 2021 15:41
@raptorsun raptorsun mentioned this pull request Sep 24, 2021
Open
@raptorsun
Copy link
Contributor Author

/test e2e-agnostic

@raptorsun raptorsun force-pushed the feature/MON-1850 branch 3 times, most recently from 7856030 to 8376b56 Compare September 27, 2021 16:18
@raptorsun
Copy link
Contributor Author

/retest-required

@raptorsun raptorsun force-pushed the feature/MON-1850 branch 3 times, most recently from defb852 to 7e9808f Compare September 29, 2021 09:14
@raptorsun
Copy link
Contributor Author

/test e2e-agnostic

@raptorsun
Copy link
Contributor Author

/retest-required

@raptorsun raptorsun force-pushed the feature/MON-1850 branch 3 times, most recently from 5fc17b8 to 8b66167 Compare September 30, 2021 09:42
@raptorsun raptorsun mentioned this pull request Sep 30, 2021
Merged
2 tasks
@raptorsun raptorsun mentioned this pull request Sep 30, 2021
Merged
2 tasks
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@simonpasquier simonpasquier mentioned this pull request Oct 14, 2021
Merged
2 tasks
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@simonpasquier
Copy link
Contributor

/skip

@simonpasquier
Copy link
Contributor

/assign @juzhao
/assign @lihongyan1

@juzhao
Copy link
Contributor

juzhao commented Oct 20, 2021 •
edited
Loading

could see the metrics from prometheus and all the targets are healthy
/lgtm

@juzhao
Copy link
Contributor

juzhao commented Oct 20, 2021 •
edited
Loading

/label qe-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

@juzhao: The label(s) /label qe-aprroved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, , backport-risk-assessed, cherry-pick-approved

In response to this:

/label qe-aprroved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juzhao, raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juzhao
Copy link
Contributor

juzhao commented Oct 20, 2021

/label qe-approved

1 similar comment
@juzhao
Copy link
Contributor

juzhao commented Oct 20, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit f06c637 into openshift:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

@slashpai slashpai Awaiting requested review from slashpai

@prashbnair prashbnair Awaiting requested review from prashbnair

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@simonpasquier simonpasquier

@juzhao juzhao

@lihongyan1 lihongyan1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@raptorsun @simonpasquier @openshift-bot @juzhao @prashbnair @openshift-merge-robot @lihongyan1