WIP: remove kube-rbac-proxy sidecar for metrics #2167
Conversation
simonpasquier
commented
Nov 23, 2023
•
simonpasquier
commented
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-ovn |
Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
remove-alertmanager-uwm-metrics-krp
branch
from
a96f8ed to
426e2af
Compare
|
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
There was a problem hiding this comment.
/close
we still need brancz/kube-rbac-proxy#146 to be fixed... In the mean time, I realize that the CMO e2e tests don't verify that the alertmanager metrics are scraped correctly...
|
@simonpasquier: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
