Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3705: [bot] Update jsonnet dependencies #2208

Conversation

openshift-monitoring-bot[bot]
Copy link

Description

This pull request updates all jsonnet dependencies listed in jsonnet/jsonnetfile.json to their latest versions and regenerates all assets.

If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository:

make update
make generate

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2023
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

Hi @openshift-monitoring-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jan--f
Copy link
Contributor

jan--f commented Dec 20, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2023
@jan--f
Copy link
Contributor

jan--f commented Dec 20, 2023

/retest

@jan--f
Copy link
Contributor

jan--f commented Dec 20, 2023

/lgtm
/label docs-approved
/label px-approved
/label qe-approved
Adding labels for a simple version bump.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Dec 20, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 20, 2023
@@ -291,7 +291,7 @@ spec:
rules:
- alert: KubePersistentVolumeFillingUp
annotations:
description: The PersistentVolume claimed by {{ $labels.persistentvolumeclaim }} in Namespace {{ $labels.namespace }} is only {{ $value | humanizePercentage }} free.
description: The PersistentVolume claimed by {{ $labels.persistentvolumeclaim }} in Namespace {{ $labels.namespace }} on Cluster {{ $labels.cluster }} is only {{ $value | humanizePercentage }} free.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

this change would introduce confusion since the cluster label isn't always set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed kubernetes-monitoring/kubernetes-mixin#887. Do we want to hold this up until then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, let's wait until we have more visibility.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 9cd8fcf to b30360b Compare December 25, 2023 01:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch 2 times, most recently from b7e0525 to e31a7f0 Compare January 8, 2024 01:10
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from e31a7f0 to e4d2d1d Compare January 15, 2024 01:11
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch 2 times, most recently from e875aa1 to 68acd68 Compare January 29, 2024 01:07
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 68acd68 to 24bc77e Compare February 5, 2024 01:06
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@openshift-monitoring-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 24bc77e link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@simonpasquier
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, openshift-monitoring-bot[bot], simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

simonpasquier commented Feb 5, 2024

/retitle MON-3705: [bot] Update jsonnet dependencies

@openshift-ci openshift-ci bot changed the title [bot] Update jsonnet dependencies MON-3705: [bot] Update jsonnet dependencies Feb 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2024

@openshift-monitoring-bot[bot]: This pull request references MON-3705 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Description

This pull request updates all jsonnet dependencies listed in jsonnet/jsonnetfile.json to their latest versions and regenerates all assets.

If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository:

make update
make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7fda01a into openshift:master Feb 5, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants