-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MON-3705: [bot] Update jsonnet dependencies #2208
MON-3705: [bot] Update jsonnet dependencies #2208
Conversation
Hi @openshift-monitoring-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/lgtm |
@@ -291,7 +291,7 @@ spec: | |||
rules: | |||
- alert: KubePersistentVolumeFillingUp | |||
annotations: | |||
description: The PersistentVolume claimed by {{ $labels.persistentvolumeclaim }} in Namespace {{ $labels.namespace }} is only {{ $value | humanizePercentage }} free. | |||
description: The PersistentVolume claimed by {{ $labels.persistentvolumeclaim }} in Namespace {{ $labels.namespace }} on Cluster {{ $labels.cluster }} is only {{ $value | humanizePercentage }} free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
this change would introduce confusion since the cluster
label isn't always set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed kubernetes-monitoring/kubernetes-mixin#887. Do we want to hold this up until then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, let's wait until we have more visibility.
9cd8fcf
to
b30360b
Compare
b7e0525
to
e31a7f0
Compare
e31a7f0
to
e4d2d1d
Compare
e875aa1
to
68acd68
Compare
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
68acd68
to
24bc77e
Compare
@openshift-monitoring-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, openshift-monitoring-bot[bot], simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle MON-3705: [bot] Update jsonnet dependencies |
@openshift-monitoring-bot[bot]: This pull request references MON-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7fda01a
into
openshift:master
Description
This pull request updates all jsonnet dependencies listed in
jsonnet/jsonnetfile.json
to their latest versions and regenerates all assets.If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository: