OCPBUGS-34544: Disable PersistentVolumeLabel admission plugin

[jsafrane]

What this PR does / why we need it:
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in HyperShift, and thus it rejects valid Azure Disk PVs.

The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway.

It's also being disabled in standalone OCP, openshift/cluster-kube-apiserver-operator#1693

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-34544
Related to OCPBUGS-31371

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

cc @openshift/storage

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-34544, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in HyperShift, and thus it rejects valid Azure Disk PVs.

The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway.

It's also being disabled in standalone OCP, openshift/cluster-kube-apiserver-operator#1693

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-34544
Related to OCPBUGS-31371

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/hold
for coordinated merge with openshift/cluster-kube-apiserver-operator#1693.

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	db98028
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/666fed7a2b55d50008babed3
😎 Deploy Preview	https://deploy-preview-4107--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[bryan-cox]

/retest

[bryan-cox]

/lgtm

[stevekuznetsov]

/assign @sjenning

[bryan-cox]

/retest

[jsafrane]

/hold cancel
The admission plugin is disabled in standalone ocp: openshift/cluster-kube-apiserver-operator#1693

[bryan-cox]

/approve

[bryan-cox]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

@jsafrane - you probably need to rebase to fix the konflux issue

[bryan-cox]

/retest

[jsafrane]

Rebased

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-azure-ovn	97548ad	link	false	/test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bryan-cox]

/test e2e-aws

[enxebre]

/lgtm

[jsafrane]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2324187 and 2 for PR HEAD db98028 in total

[openshift-ci-robot]

@jsafrane: Jira Issue OCPBUGS-34544: All pull requests linked via external trackers have merged:

• openshift/hypershift#4107
• openshift/cluster-kube-apiserver-operator#1693
• openshift/kubernetes#1986
• openshift/kubernetes#1991

Jira Issue OCPBUGS-34544 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in HyperShift, and thus it rejects valid Azure Disk PVs.

The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway.

It's also being disabled in standalone OCP, openshift/cluster-kube-apiserver-operator#1693

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-34544
Related to OCPBUGS-31371

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@jsafrane: new pull request created: #4241

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.