-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.18] OCPBUGS-48790: Add a liveness probe to the extractor container #1068
base: release-4.18
Are you sure you want to change the base?
[release-4.18] OCPBUGS-48790: Add a liveness probe to the extractor container #1068
Conversation
@jmesnil: This pull request references Jira Issue OCPBUGS-48790, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jmesnil: This pull request references Jira Issue OCPBUGS-48790, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmesnil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@jmesnil: This pull request references Jira Issue OCPBUGS-48790, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The extractor container relies on critctl to collect container information If the crio.service is restarted on the worker nodes when the CA bundle has been updated by the proxy/cluster, the container would not be able to connect anymore on the restarted CRI-O service. Adding a liveness probe that check that crictl works as expected ensure that the container will be killed and restarted with the correct TLS settings to connect to the CRI-O service. This fixes https://issues.redhat.com/browse/OCPBUGS-48790. Upstream PR is openshift#1067. Signed-off-by: Jeff Mesnil <[email protected]>
2c6a76d
to
6ac3354
Compare
@jmesnil: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The extractor container relies on critctl to collect container information
If the crio.service is restarted on the worker nodes when the CA bundle has been updated by the proxy/cluster, the container would not be able to connect anymore on the restarted CRI-O service.
Adding a liveness probe that check that crictl works as expected ensure that the container will be killed and restarted with the correct TLS settings to connect to the CRI-O service.
This fixes https://issues.redhat.com/browse/OCPBUGS-48790.
Upstream PR is #1067.
Categories
Breaking Changes
No
References
https://issues.redhat.com//browse/OCPBUGS-48790