Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.18] OCPBUGS-48790: Add a liveness probe to the extractor container #1068

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Jan 23, 2025

The extractor container relies on critctl to collect container information

If the crio.service is restarted on the worker nodes when the CA bundle has been updated by the proxy/cluster, the container would not be able to connect anymore on the restarted CRI-O service.

Adding a liveness probe that check that crictl works as expected ensure that the container will be killed and restarted with the correct TLS settings to connect to the CRI-O service.

This fixes https://issues.redhat.com/browse/OCPBUGS-48790.

Upstream PR is #1067.

Categories

  • Bugfix
  • Backporting

Breaking Changes

No

References

https://issues.redhat.com//browse/OCPBUGS-48790

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 23, 2025
@openshift-ci-robot
Copy link
Contributor

@jmesnil: This pull request references Jira Issue OCPBUGS-48790, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48154 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The extractor container relies on critctl to collect container information

If the crio.service is restarted on the worker nodes when the CA bundle has been updated by the proxy/cluster, the container would not be able to connect anymore on the restarted CRI-O service.

Adding a liveness probe that check that crictl works as expected ensure that the container will be killed and restarted with the correct TLS settings to connect to the CRI-O service.

This fixes https://issues.redhat.com/browse/OCPBUGS-48790.

Upstream PR is #1067.

Categories

  • Bugfix
  • Backporting

Breaking Changes

No

References

https://issues.redhat.com//browse/OCPBUGS-48790
https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmesnil
Copy link
Contributor Author

jmesnil commented Jan 23, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jmesnil: This pull request references Jira Issue OCPBUGS-48790, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48154 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ncaak and tremes January 23, 2025 08:51
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmesnil
Once this PR has been reviewed and has the lgtm label, please assign ncaak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmesnil
Copy link
Contributor Author

jmesnil commented Jan 23, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jmesnil: This pull request references Jira Issue OCPBUGS-48790, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48154 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tremes tremes changed the title OCPBUGS-48790: Add a liveness probe to the extractor container [release-4.18] OCPBUGS-48790: Add a liveness probe to the extractor container Jan 23, 2025
The extractor container relies on critctl to collect container information

If the crio.service is restarted on the worker nodes when the CA bundle has
been updated by the proxy/cluster, the container would not be able to connect
anymore on the restarted CRI-O service.

Adding a liveness probe that check that crictl works as expected ensure that
the container will be killed and restarted with the correct TLS settings to
connect to the CRI-O service.

This fixes https://issues.redhat.com/browse/OCPBUGS-48790.

Upstream PR is openshift#1067.

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil jmesnil force-pushed the OCPBUGS-48790_insights_runtime_extractor_liveness_probe branch from 2c6a76d to 6ac3354 Compare January 23, 2025 12:58
Copy link

openshift-ci bot commented Jan 23, 2025

@jmesnil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 6ac3354 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/unit 6ac3354 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants