Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: add test-e2e-monitoring placeholder test #1836

Closed

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Oct 16, 2024

should unblock #1823

it works on my local machine:

make test-e2e-monitoring
go test -mod=vendor -race ./test/e2e-monitoring/...
ok  	github.com/openshift/library-go/test/e2e-monitoring	(cached)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request explicitly references no jira issue.

In response to this:

should unblock #1823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial p0lyn0mial force-pushed the run-monitoring-integratin-test branch from 3c9f8a1 to 21551d6 Compare October 16, 2024 11:38
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Contributor Author

OK, ci/prow/e2e-monitoring run TestResourceVersionApplication.

@p0lyn0mial
Copy link
Contributor Author

/assign @dgrisonnet @rexagod

@p0lyn0mial p0lyn0mial added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet
Copy link
Member

I think we should activate the test-e2e-monitoring rule in #1823 instead.

@p0lyn0mial
Copy link
Contributor Author

/close

pulled into #1823

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@p0lyn0mial: Closed this PR.

In response to this:

/close

pulled into #1823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants