Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-48344: Make the revision controller report degraded on error #1920

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[release-4.18] OCPBUGS-48344: Make the revision controller report degraded on error #1920

merged 1 commit into from
Jan 28, 2025
+15 −65

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1918

/assign benluddy

@deads2k
Make the revision controller report degraded on error
9b39168 
This makes the error handling slightly easier, keeps the retry on error
logic, leaves the requeue on self-modification we rely upon.

This doesn't introduce VAP to prevent writes to "immutable" configmaps
and secrets, but I'm open to doing that to prevent stale caches from
creating unstable and inconsistent revisions.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 13, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-48276 has been cloned as Jira Issue OCPBUGS-48344. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-48344: Make the revision controller report degraded on error

In response to this:

This is an automated cherry-pick of #1918

/assign benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-48276: Make the revision controller report degraded on error [release-4.18] OCPBUGS-48344: Make the revision controller report degraded on error Jan 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48344, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1918

/assign benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-48344, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48276 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48276 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 January 22, 2025 15:35
dgrisonnet
dgrisonnet approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Holding for the proof PR
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@benluddy
Copy link
Contributor

/hold cancel
/assign @p0lyn0mial

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@p0lyn0mial
Copy link
Contributor

I think that this PR simplifies reporting the degraded condition. It won’t solve the issue with decreasing the LatestAvailableRevision.

openshift/api#2038 - prevents LatestAvailableRevision from being decreased.

So, I think that this PR reduces frequency of changes to LatestAvailableRevision and as a result reduces potential conflicts to LatestAvailableRevision.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, openshift-cherrypick-robot, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a69305d into openshift:release-4.18 Jan 28, 2025
4 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-48344: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-48344 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1918

/assign benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@hexfusion hexfusion Awaiting requested review from hexfusion

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@benluddy benluddy

@p0lyn0mial p0lyn0mial

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @benluddy @p0lyn0mial @dgrisonnet @deads2k