Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing LISTENING port states to the list of states reported in metrics #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edcdavid
Copy link
Contributor

@edcdavid edcdavid commented Nov 20, 2024

This is to add support for the LISTENING port state in metrics. Using a new integer value 5 for backward compatibility (so as to not change previous mappings).
The LISTENING state is reached when multiple follower ports are receiving PTP frames but only one is selected to become a SLAVE, in slave only mode. The other ports state should be LISTENING (whether they receive PTP frames are received or not).

…Using a new integer value 5 for backward compatibility (so as to not change previous mappings)
@openshift-ci openshift-ci bot requested review from jzding and SchSeba November 20, 2024 17:17
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edcdavid
Once this PR has been reviewed and has the lgtm label, please assign schseba for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edcdavid
Copy link
Contributor Author

/retest

@aneeshkp
Copy link
Contributor

you might have to do the same to cloud-event-proxy

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@edcdavid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants