-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-5043: add http header modification feature #56177
Conversation
@miheer could you PTAL for SME feedback? This PR contains a doc update for NE-982, adding HTTP headers to HAProxy. There are some gaps in my knowledge here, your feedback is appreciated. Thank you 🙇 |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28795 |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.14 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ba4a480
to
a107c4e
Compare
ba4a480...a107c4e modify ingress example |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann I see there are still some items missing as per the google doc I had shared with you. Are you still working on this PR ? |
@miheer yes, I'll ping you when it's ready for review 🙂 |
@miheer that is small enough to add as a note to the existing procedure that uses the dynamic header value. What do you think of the rest of the content in the PR? |
82511f0
to
36dbc59
Compare
@ShudiLi can you PTAL for QE ack? This PR adds the content for the new feature allowing users to set or delete certain HTTP request and response headers. Thank you! |
The PR looks fine to me. We are just working X-Forwaders-For chart. I will keep you posted. |
@jldohmann for now lets remove the X-Forwaders-For chart. We can include it sometime in the future once my chart in the revised EP openshift/enhancements#1446 is finalised. |
36dbc59
to
0d507c3
Compare
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, added some feedback!
/label peer-review-done |
314e692
to
0f4a8cd
Compare
Just find a mirror issue, others look good to me, thanks. |
0f4a8cd
to
d88ecc0
Compare
@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d88ecc0
to
affb99d
Compare
affb99d
to
756d2e4
Compare
/cherrypick enterprise-4.14 |
@jldohmann: new pull request created: #66515 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.14+
Issue: https://issues.redhat.com/browse/OSDOCS-5043
Link to docs preview:
QE review:
Additional information: