Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-5043: add http header modification feature #56177

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Feb 20, 2023

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2023
@jldohmann
Copy link
Contributor Author

@miheer could you PTAL for SME feedback? This PR contains a doc update for NE-982, adding HTTP headers to HAProxy. There are some gaps in my knowledge here, your feedback is appreciated. Thank you 🙇

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 20, 2023

🤖 Updated build preview is available at:
https://56177--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28795

@jldohmann jldohmann added this to the Planned for 4.13 GA milestone Feb 20, 2023
@jldohmann jldohmann changed the title add http header modification feature OSDOCS-5043: add http header modification feature Apr 5, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 5, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-5043/networking/ingress-operator.html#nw-ingress-add-http-headers_configuring-ingress

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

The branch/enterprise-4.14 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.13. And any PR going into main must also target the latest version branch (enterprise-4.14).

If the update in your PR does NOT apply to version 4.14 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 9, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-5043/networking/ingress-operator.html#nw-ingress-add-http-headers_configuring-ingress

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann force-pushed the OSDOCS-5043 branch 3 times, most recently from ba4a480 to a107c4e Compare October 2, 2023 23:59
@jldohmann
Copy link
Contributor Author

ba4a480...a107c4e modify ingress example

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview:

  • Setting or deleting HTTP request and response headers
  • Ingress Controller configuration parameters

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 4, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 4, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miheer
Copy link

miheer commented Oct 9, 2023

@jldohmann I see there are still some items missing as per the google doc I had shared with you. Are you still working on this PR ?

@jldohmann
Copy link
Contributor Author

@miheer yes, I'll ping you when it's ready for review 🙂

@jldohmann
Copy link
Contributor Author

@miheer that is small enough to add as a note to the existing procedure that uses the dynamic header value. What do you think of the rest of the content in the PR?

@jldohmann
Copy link
Contributor Author

@ShudiLi can you PTAL for QE ack? This PR adds the content for the new feature allowing users to set or delete certain HTTP request and response headers. Thank you!

@miheer
Copy link

miheer commented Oct 17, 2023

The PR looks fine to me. We are just working X-Forwaders-For chart. I will keep you posted.

@miheer
Copy link

miheer commented Oct 17, 2023

@jldohmann for now lets remove the X-Forwaders-For chart. We can include it sometime in the future once my chart in the revised EP openshift/enhancements#1446 is finalised.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 17, 2023
@bergerhoffer
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 17, 2023
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, added some feedback!

modules/nw-http-header-configuration.adoc Show resolved Hide resolved
modules/nw-http-header-configuration.adoc Outdated Show resolved Hide resolved
modules/nw-http-header-configuration.adoc Outdated Show resolved Hide resolved
modules/nw-http-header-configuration.adoc Outdated Show resolved Hide resolved
modules/nw-ingress-set-or-delete-http-headers.adoc Outdated Show resolved Hide resolved
modules/nw-route-set-or-delete-http-headers.adoc Outdated Show resolved Hide resolved
modules/nw-route-set-or-delete-http-headers.adoc Outdated Show resolved Hide resolved
modules/nw-route-set-or-delete-http-headers.adoc Outdated Show resolved Hide resolved
modules/nw-route-set-or-delete-http-headers.adoc Outdated Show resolved Hide resolved
@bergerhoffer
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 17, 2023
@jldohmann jldohmann force-pushed the OSDOCS-5043 branch 2 times, most recently from 314e692 to 0f4a8cd Compare October 17, 2023 21:57
@ShudiLi
Copy link
Member

ShudiLi commented Oct 18, 2023

Just find a mirror issue, others look good to me, thanks.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2023

@jldohmann: This pull request references OSDOCS-5043 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-5043

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann
Copy link
Contributor Author

d88ecc0..756d2e4 just various typo fixes and final cleanups

@jldohmann jldohmann merged commit 9589165 into openshift:main Oct 18, 2023
@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@jldohmann: new pull request created: #66515

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann deleted the OSDOCS-5043 branch October 18, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants