Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing azure-disk test in Hypershift Azure conformance tests. #53570

Conversation

Patryk-Stefanski
Copy link
Contributor

Removing azure-disk test skips in Hypershift Azuer conformance tests as PVL tests have now been disabled in upstream

@openshift-ci openshift-ci bot requested review from csrwng and sjenning June 24, 2024 08:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Patryk-Stefanski: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-azure-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-azure-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-azure-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-azure-ovn-conformance openshift/hypershift presubmit Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-azure-ovn-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-azure-ovn-conformance N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Patryk-Stefanski
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-azure-ovn-conformance

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Patryk-Stefanski
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-release-4.16-e2e-azure-ovn-conformance

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
@csrwng
Copy link
Contributor

csrwng commented Jun 24, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, Patryk-Stefanski, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csrwng
Copy link
Contributor

csrwng commented Jun 24, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@csrwng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 68afcdd into openshift:master Jun 24, 2024
14 checks passed
cplacani pushed a commit to cplacani/release that referenced this pull request Jun 25, 2024
JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Jul 2, 2024
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants