Add new e2e-monitoring test to library-go

[dgrisonnet]

New test added in openshift/library-go#1823

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@dgrisonnet: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-library-go-master-e2e-monitoring	openshift/library-go	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[dgrisonnet]

/pj-rehearse ack

[openshift-ci-robot]

@dgrisonnet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[rexagod]

/pj-rehearse ack

[openshift-ci-robot]

@rexagod: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[deads2k]

make sure this runs prior to merge. Feel free to release after.

/approve
/hold

[dgrisonnet]

/pj-rehearse pull-ci-openshift-library-go-master-e2e-monitoring

[openshift-ci-robot]

@dgrisonnet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[p0lyn0mial]

ci/rehearse/openshift/library-go/master/e2e-monitoring is green.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dgrisonnet, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/library-go/OWNERS [deads2k]
• ci-operator/jobs/openshift/library-go/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[p0lyn0mial]

/hold cancel

[rexagod]

/hold

Did the test actually run?

make: Nothing to be done for 'test-e2e-monitoring'.

[dgrisonnet]

Did the test actually run?

make: Nothing to be done for 'test-e2e-monitoring'.

This is the expected result, it ran but we just added a placeholder Makefile rule (openshift/library-go#1829)

[rexagod]

ACK, apologies for blocking the original PR, and PLMK if I'm missing something here, but shouldn't the integration tests actually run on PRs and actively block them if they fail? This is in line with the fact that vetting master currently fails for encryption_test.go as that signature was changed, but uncaught. Despite this being a compilation error rather than a logical one, I'd root for an integration suite that runs these tests over a go vet step (over a placeholder step).

cc @p0lyn0mial

[dgrisonnet]

ACK, apologies for blocking the original PR, and PLMK if I'm missing something here, but shouldn't the integration tests actually run on PRs and actively block them if they fail?

Yes but we don't really need to run them if the code path hasn't been touched.

Despite this being a compilation error rather than a logical one, I'd root for an integration suite that runs these tests over a go vet step

If the reason was logical it would be flagged by the integration test since the code path would be touched. But here it is just a compilation error that can easily be caught once we try to update the dependency in one of the consumer, we don't really need to run the integration suite for that?

[dgrisonnet]

The placeholder step is just here because pj-rehearse doesn't support targeting a specific PR. We have to first merge the PR here with a test that is never failing and then update the rule in the library-go PR to test the code and verify that the new integration test works.

[dgrisonnet]

/unhold

[rexagod]

Ah, I see, the integration tests have been split up into separate targets so they can be run lazily based on the related codepath changes. However, it seems the e2e-encryption suite had its rule here added later on as it's still just a placeholder, but I'll send a patch to fix it, thanks for the clarification!