Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/db authentication with azure identity token #724

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

IanR01
Copy link

@IanR01 IanR01 commented Jan 27, 2025

Changes to the api- and auth-server, so a database (MySQL) connection can be made in an Azure context (in this case specific for Amsterdam):

  • a little refactoring of the code setting the SSL config
  • option to set 'require ssl' with the env DB_REQUIRE_SSL
  • prepared the code for additional database authentication methods, by setting the DB_AUTH_METHOD env-var
  • added the 'azure-auth-token' option for DB_AUTH_METHOD, using a WorkloadIdentityCredential from the @azure/identity package

@IanR01 IanR01 marked this pull request as ready for review January 27, 2025 15:55
@rudivanhierden rudivanhierden changed the base branch from main to develop January 29, 2025 07:54
Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code looks fine, although there is some repeated files — but we will need to ensure that general packages are loaded for auth-server first before we can refactor that into a package, so that's fine for this PR.

Can you maybe supply some documentation about how to connect to the database through Azure? It's a new use-case that we are not familiar with, so any extra information would be very helpful 💪

@IanR01 IanR01 requested a review from rudivanhierden January 29, 2025 14:06
@IanR01
Copy link
Author

IanR01 commented Jan 29, 2025

Gerelateerd ticket: https://openstad.dev/ticket?openstadResourceId=165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants