Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub actions #1698

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix GitHub actions #1698

merged 4 commits into from
Jan 30, 2025

Conversation

mkrnr
Copy link
Contributor

@mkrnr mkrnr commented Jan 28, 2025 •
edited
Loading

Summary of changes

Fixes the currently broken GitHub actions (see e.g. this run):

  1. Bump the GitHub action runner macOS version since macOS-12 is deprecated, resulting in the test being skipped
  2. Bump the ubuntu version to 24.04 since it's not causing issues (Windows 2025 does create issues so leaving that out for now)
  3. Bump twine to 3.7.0 to support metadata 2.2 which is otherwise breaking the packaging build
  4. Bump pkginfo to 1.8.1 which is required by twine 3.7.0
  5. Bump the GitHub actions versions to remove deprecation warnings
  6. Update when the GitHub actions are triggered to prevent double executions (both triggered by push and pull_request)

I don't think it makes sense to add a news fragment since this is a technical change related to CI/CD.

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

@mkrnr mkrnr force-pushed the fix-github-actions branch from cb210a8 to 88828c3 Compare January 28, 2025 20:31
@mkrnr mkrnr self-assigned this Jan 28, 2025
@mkrnr mkrnr marked this pull request as ready for review January 29, 2025 06:10
@mkrnr mkrnr changed the title [WIP] Fix GitHub actions Fix GitHub actions Jan 29, 2025
@mkrnr mkrnr requested a review from a team January 29, 2025 18:04
greenwyrt
greenwyrt approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@greenwyrt greenwyrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the change in #1687 doesn't make sense (now closed), I don't think there are any potential conflicts

@mkrnr mkrnr merged commit 7a6e63d into main Jan 30, 2025
12 checks passed
@mkrnr mkrnr deleted the fix-github-actions branch January 30, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenwyrt greenwyrt greenwyrt approved these changes

Assignees

@mkrnr mkrnr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkrnr @greenwyrt