What happened to the notes on the map?

[maro-21]

Have there been any recent changes to the code regarding the display of notes?

So far, when I opened the map of my city on zoom 12, I could see all the notes (about 100). Now I see only a dozen or so. Zooming in to z13 or z14 doesn't show all the notes either. What happened? Is it a bug or a deliberate action? I don't know how to look for notes now.

[danieldegroot2]

This issue is likely a duplicate of (part of) #3831; a note in view may be causing a javascript error, causing some notes not to display. Also, see this comment on your previous issue.

[maro-21]

I think this problem with the notes started in early March.

[danieldegroot2]

Could you provide a link to the general area you are viewing on OpenStreetMap (without specific place selected is fine), please? Then someone else could try looking into it.

[tomhughes]

There have been no such changes. Nobody has touched the notes code for many months.

[maro-21]

There have been no such changes. Nobody has touched the notes code for many months.

Thank you for the answer.
So is this behavior related to #2146?

[tomhughes]

No idea. If it is then it would require the person that opened a lot of notes in the area to have closed their account. Mostly though it's impossible to comment as you haven't provided any idea as to what area you are talking about.

[AntonKhorev]

It is related to this: #3617

So far, when I opened the map of my city on zoom 12, I could see all the notes (about 100).

You can't see more than 100 notes with osm.org note layer.

Now I see only a dozen or so.

You'll see notes up to the first one without visible comments, then the javascript code will fail.

I don't know how to look for notes now.

Use my notes viewer:
https://antonkhorev.github.io/osm-note-viewer/#mode=bbox&bbox=16.7390%2C50.9398%2C17.3021%2C51.2821&closed=7&map=11/51.1074/17.0171

[maro-21]

Could you provide a link to the general area you are viewing on OpenStreetMap

https://www.openstreetmap.org/#map=12/51.1069/17.0027&layers=N

You'll see notes up to the first one without visible comments, then the javascript code will fail.

When does this happen? Is it when the user who created or commented on the note has deleted the account?
How can one create a note without a comment? I understand that not using popular editors and OSM applications?
Or by "not visible comment" you mean a comment that was hidden by a moderator?

[tomhughes]

Ah right that makes more sense now you've explained there is a javascript exception.

Yes indeed it is failing looking up the initial comment for a note, so this is a duplicate of #2146.

[maro-21]

so this is a duplicate of #2146.

I think it's connected but not the same. The issue #2146 is about a server error when trying to display a note. This one is about notes not displaying on the map because of a JavaScript error.

[AntonKhorev]

You'll see notes up to the first one without visible comments, then the javascript code will fail.

When does this happen? Is it when the user who created or commented on the note has deleted the account?

That's the most likely scenario.

How can one create a note without a comment?

You can't:

openstreetmap-website/app/controllers/api/notes_controller.rb

Line 91 in c8f6d6d

# Include in a transaction to ensure that there is always a note_comment for every note

Or by "not visible comment" you mean a comment that was hidden by a moderator?

That didn't get merged too: #3438