Raise error when note has no comments

[jguthrie100]

Temporary fix for #2146

• Raises RecordNotFound exception when note has no comments (avoiding 500 Error)

[tomhughes]

This definitely needs a test but more significantly I'm not sure this is really the right fix. I have a feeling that the visible scope on notes should exclude these but that turns out to be non-trivial to do...

Still thinking about the best way to deal with it really.

[jguthrie100]

The problem is that @note_comments is nil, but in the view, a request is made for @note_comments.first, which then causes a crash.

So either the view needs to be rewritten to handle a case where there are no comments, or the view needs to not be called in the first place..

[jguthrie100]

The line that crashes is:

openstreetmap-website/app/views/browse/note.html.erb

Lines 10 to 13 in 874fddf

	<div class="note-description">
	<%= h(@note_comments.first.body.to_html) %>
	</div>

[jguthrie100]

Unless a new error is raised: ActiveRecord::RecordDeleted, which opens the comments page, but notes the comments that have been deleted?

[jguthrie100]

This definitely needs a test but more significantly I'm not sure this is really the right fix. I have a feeling that the visible scope on notes should exclude these but that turns out to be non-trivial to do...

What do you mean by "exclude these"? What should be excluded?

[mmd-osm]

#3608 supersedes this pull request.