Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace var in javascript with let/const #5558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace var in javascript with let/const #5558

wants to merge 2 commits into from

Conversation

tomhughes
Copy link
Member

This updates the eslint config to prohibit use of var and to prefer const over let and then fixes all uses of var to respect that.

@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?

Generated by 🚫 Danger

@AntonKhorev
Copy link
Collaborator

and then fixes all uses of var to respect that

Not in unmerged pull requests.

@HolgerJeromin HolgerJeromin mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HolgerJeromin HolgerJeromin HolgerJeromin approved these changes

Assignees
No one assigned
Labels
big-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomhughes @AntonKhorev @HolgerJeromin