Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change config params to match new name #721

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Jul 29, 2024

✨ Context

Some parameter names were not changed with the update #641 f79c789.
This PR attempts to resolve them.

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@project-defiant project-defiant requested a review from DSuveges July 29, 2024 09:21
@github-actions github-actions bot added bug Something isn't working size-XS labels Jul 29, 2024
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be fine.

@DSuveges DSuveges merged commit a5c96b9 into dev Jul 29, 2024
4 checks passed
@project-defiant project-defiant deleted the szsz-fix-incorrect-parameter-name branch July 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size-XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants