-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(l2g_predictions): annotate based on list of features + filter out missing annotation #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, how many features did we add additionally to the predictions with last run that we do not care about?
) -> L2GPrediction: | ||
"""Add features to the L2G predictions. | ||
"""Add features used to extract the L2G predictions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It extracts the features
based on features_list
from L2GFeatureMatrix
and reannotates the locusToGeneFeatures
column with the map constructed from extracted features if the column exists or
creates the column when it is missing from the schema.
|
||
Args: | ||
feature_matrix (L2GFeatureMatrix): Feature matrix dataset | ||
features_list (list[str]): List of features used in the model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of features to extract from feature matrix.
@project-defiant One: Thanks for the review! |
✨ Context
The feature matrix contains all features we have developed for L2G.
However, that doesn't mean that we want to use all of them during training. Right now, this is true for
isProteinCoding
.🛠 What does this PR implement
add_locus_to_gene_features
didn't take into account the list of features used for training. Now it does🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?